-
- Downloads
Binary size: push_constant_text -> push_text when not time-critical.
Especially in error handling, and code that does a lot of other string operations anyway the speed gain is not wort the 100+ bytes code size of each instance of push_constant_text This saves about 20K of code size (main pike binary), while not really changing the speed much. push_constant_text that seemed to be in at least pseudo-time-critical code was kept as they were. On a related note, push_constant_text(":") four times in a row creates four different string variables, for obvious reasons. Some of the remaining push_constant_text really should have a module/file local string variable, even though that is more bothersome to create. It might be nice to have this in .cmod files automatically.
Showing
- src/backend.cmod 1 addition, 1 deletionsrc/backend.cmod
- src/builtin.cmod 27 additions, 27 deletionssrc/builtin.cmod
- src/builtin_functions.c 4 additions, 4 deletionssrc/builtin_functions.c
- src/cpp.c 11 additions, 11 deletionssrc/cpp.c
- src/dynamic_load.c 1 addition, 1 deletionsrc/dynamic_load.c
- src/encode.c 4 additions, 4 deletionssrc/encode.c
- src/error.c 1 addition, 1 deletionsrc/error.c
- src/gc.c 23 additions, 23 deletionssrc/gc.c
- src/modules/Gettext/gettext.c 2 additions, 2 deletionssrc/modules/Gettext/gettext.c
- src/modules/Gmp/mpf.cmod 8 additions, 5 deletionssrc/modules/Gmp/mpf.cmod
- src/modules/Gmp/mpq.cmod 10 additions, 7 deletionssrc/modules/Gmp/mpq.cmod
- src/modules/Gmp/mpz_glue.c 13 additions, 15 deletionssrc/modules/Gmp/mpz_glue.c
- src/modules/HTTPLoop/accept_and_parse.c 9 additions, 9 deletionssrc/modules/HTTPLoop/accept_and_parse.c
- src/modules/HTTPLoop/requestobject.c 2 additions, 2 deletionssrc/modules/HTTPLoop/requestobject.c
- src/modules/Image/colors.c 8 additions, 8 deletionssrc/modules/Image/colors.c
- src/modules/Image/colortable.c 10 additions, 10 deletionssrc/modules/Image/colortable.c
- src/modules/Image/encodings/avs.c 3 additions, 3 deletionssrc/modules/Image/encodings/avs.c
- src/modules/Image/encodings/dsi.c 3 additions, 3 deletionssrc/modules/Image/encodings/dsi.c
- src/modules/Image/encodings/hrz.c 1 addition, 1 deletionsrc/modules/Image/encodings/hrz.c
- src/modules/Image/encodings/neo.c 11 additions, 11 deletionssrc/modules/Image/encodings/neo.c
Loading
Please register or sign in to comment