pgsql: Protect against execution in destructed objects.

lib/modules/Sql.pmod/pgsql.pike

@@ -612,17 +612,15 @@ final void _processloop(.pgsql_util.conxion ci) {
     plugbuffer->add_int8(0);
     PD("%O\n",(string)plugbuffer);
     if(catch(ci->start()->add_hstring(plugbuffer,4,4)->sendcmd(SENDOUT))) {
-#ifdef PG_DEBUG
-      if(!_options)
-        PD("_options is zero, %O\n",this);
-#endif
-      if(_options && _options.reconnect)	// FIXME why can _options be 0?
+      if(this)				// Only when not destructed yet
+        if(_options.reconnect)
           _connectfail();
         else
           destruct(waitforauthready);
-    } else	      // Do not flush at this point, PostgreSQL 9.4 disapproves
-      procmessage();
+      return;
     }
+  }		      // Do not flush at this point, PostgreSQL 9.4 disapproves
+  procmessage();
 }
 
 private void procmessage() {
@@ -1174,6 +1172,7 @@ private void procmessage() {
     break;
   }
   PD("Closing database processloop %O\n",err);
+  if(this)
     _delayederror=err;
   for(;objectp(portal);portal=qportals->read())
     if(objectp(portal)) {
@@ -1184,9 +1183,9 @@ private void procmessage() {
     }
   if(!ci->close() && !terminating && _options.reconnect)
     _connectfail();
-  else
+  else if(this)
     destruct(waitforauthready);
-  if(err && !stringp(err))
+  if(this && err && !stringp(err))
     throw(err);
 }
 

lib/modules/Sql.pmod/pgsql_util.pmod

@@ -207,8 +207,8 @@ class conxiin {
   final int read_cb(mixed id,mixed b) {
     PD("Read callback %O\n",(string)b);
     Thread.MutexKey lock=fillreadmux->lock();
-    if(procmsg)
-      procmsg=0,lock=0,Thread.Thread(id());
+    if(procmsg&&id)
+      procmsg=0,lock=0,Thread.Thread(id);
     else if(fillread)
       didreadcb=1, fillread.signal();
     lock=0;