Rewrite code that uses the old type-checker APIs
There are several functions in pike_types.cmod
that are only used from a single or a couple of places, that there are alternative functions with the functionality for.
-
check_call()
Only used by the type checkers for
foreach
and the range operator (twice each). -
low_get_return_type()
Only used by
check_call()
. -
strict_check_call()
Only used by itself and
check_call()
. -
count_arguments()
Only used by
is_stupid_func()
anddo_opt_code()
. -
low_count_arguments()
Only used by itself and
count_arguments()
. -
minumum_arguments()
Only used by
is_stupid_func()
. -
low_minimum_arguments()
Only used by itself and
minimum_arguments()
.
Rewriting the type checkers for foreach
and the range operator would thus make it possible to remove the first three of the above.
Update the following functions:
-
fix_foreach_type()
-
low_range_type()
-
is_stupid_func()
-
dooptcode()