GitLab

Imported from http://bugzilla.roxen.com/bugzilla/show_bug.cgi?id=3199

Reported by Dan Nelson dnelson_1901@yahoo.com

The Oracle module's configure.in is a maze of twisty "check to see if this file exists" tests, and doesn't check for Oracle 9 libraries.

It probably should be rewritten using AC_SEARCH_LIBS, since it seems Oracle has standardised on "-lclntsh" for shlib usage since Oracle 8, and Oracle 9 has added a libclntst.a for static linking.

But, here's a simple fix in the meantime :)

cvs server: Diffing .
Index: configure.in
===================================================================
RCS file: /cvs/Pike/7.3/src/modules/Oracle/configure.in,v
retrieving revision 1.33
diff -u -r1.33 configure.in
--- configure.in        2002/01/27 00:54:00     1.33
+++ configure.in        2002/08/07 14:13:48
@@ -88,7 +88,8 @@
   else
     if test x"$pike_cv_oracle_oracle_home" != xno && \
        test -f "$pike_cv_oracle_oracle_home/lib/libcommon.a" -o \
-             -f "$pike_cv_oracle_oracle_home/lib/libcommon8.a"; then
+            -f "$pike_cv_oracle_oracle_home/lib/libcommon8.a" -o \
+            -f "$pike_cv_oracle_oracle_home/lib/libcommon9.a"; then

   echo "$pike_cv_oracle_oracle_home/lib" > conftest

@@ -96,7 +97,7 @@ if test x"$pike_cv_oracle_oratab_file" = xno; then :; else

         sed -e '/^#/d' < $pike_cv_oracle_oratab_file | while IFS=":" read
sid dir bootstart; do
-          if test -d "$dir/." && test -f "$dir/lib/libcommon.a" -o -f
"$dir/lib/libcommon8.a"; then
+          if test -d "$dir/." && test -f "$dir/lib/libcommon.a" -o -f
"$dir/lib/libcommon8.a" -o -f "$dir/lib/libcommon9.a"; then
            if test x"$pike_cv_oracle_oracle_home" = xno; then
              AC_DEFINE_UNQUOTED(ORACLE_HOME, "${dir}")
            else
@@ -210,7 +211,8 @@
     if test "x$pike_cv_sys_os" = "xWindows_NT"; then
       ORACLE_LIBS="-loci"
     else
-      if test -f "$oracle_lib_dir/libcommon8.a"; then
+      if test -f "$oracle_lib_dir/libcommon8.a" -o \
+              -f "$oracle_lib_dir/libcommon9.a" ; then
         ORACLE_LIBS="-lclntsh"
       else
         if test -f "$oracle_lib_dir/libcore4.a"; then