Skip to content
Snippets Groups Projects
Commit 9f238b7d authored by Niels Möller's avatar Niels Möller
Browse files

In tests, delete ASSERTs with functions pointer comparisons.

parent a213dbd3
Branches
Tags
No related merge requests found
2020-04-23 Niels Möller <nisse@lysator.liu.se>
* testsuite/ecc-add-test.c (test_main): Delete ASSERTs with
functions pointer comparisons. They provide little value, and fail
when linking with hogweed.dll on windows.
* testsuite/ecc-dup-test.c (test_main): Likewise.
2020-04-22 Niels Möller <nisse@lysator.liu.se> 2020-04-22 Niels Möller <nisse@lysator.liu.se>
* testsuite/Makefile.in: Use pattern rules for test executables, * testsuite/Makefile.in: Use pattern rules for test executables,
......
...@@ -23,10 +23,6 @@ test_main (void) ...@@ -23,10 +23,6 @@ test_main (void)
{ {
mp_limb_t *z = xalloc_limbs (ecc_size_j (ecc)); mp_limb_t *z = xalloc_limbs (ecc_size_j (ecc));
ASSERT ((ecc->p.bit_size == 255 && ecc->add_hh == ecc_add_th)
|| (ecc->p.bit_size == 448 && ecc->add_hh == ecc_add_eh));
ASSERT ((ecc->p.bit_size == 255 && ecc->add_hhh == ecc_add_thh)
|| (ecc->p.bit_size == 448 && ecc->add_hhh == ecc_add_ehh));
ASSERT (ecc->add_hh_itch <= ecc->add_hhh_itch); ASSERT (ecc->add_hh_itch <= ecc->add_hhh_itch);
/* Zero point has x = 0, y = 1, z = 1 */ /* Zero point has x = 0, y = 1, z = 1 */
...@@ -53,11 +49,6 @@ test_main (void) ...@@ -53,11 +49,6 @@ test_main (void)
free (z); free (z);
} }
else
{
ASSERT (ecc->add_hhh == ecc_add_jjj);
ASSERT (ecc->dup == ecc_dup_jj);
}
ecc->dup (ecc, g2, g, scratch); ecc->dup (ecc, g2, g, scratch);
test_ecc_mul_h (i, 2, g2); test_ecc_mul_h (i, 2, g2);
......
...@@ -18,9 +18,6 @@ test_main (void) ...@@ -18,9 +18,6 @@ test_main (void)
{ {
mp_limb_t *z = xalloc_limbs (ecc_size_j (ecc)); mp_limb_t *z = xalloc_limbs (ecc_size_j (ecc));
ASSERT ((ecc->p.bit_size == 255 && ecc->dup == ecc_dup_th)
|| (ecc->p.bit_size == 448 && ecc->dup == ecc_dup_eh));
/* Zero point has x = 0, y = 1, z = 1 */ /* Zero point has x = 0, y = 1, z = 1 */
mpn_zero (z, 3*ecc->p.size); mpn_zero (z, 3*ecc->p.size);
z[ecc->p.size] = z[2*ecc->p.size] = 1; z[ecc->p.size] = z[2*ecc->p.size] = 1;
...@@ -30,8 +27,6 @@ test_main (void) ...@@ -30,8 +27,6 @@ test_main (void)
free (z); free (z);
} }
else
ASSERT (ecc->dup == ecc_dup_jj);
ecc->dup (ecc, p, g, scratch); ecc->dup (ecc, p, g, scratch);
test_ecc_mul_h (i, 2, p); test_ecc_mul_h (i, 2, p);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment